ndpi: add ndpi as a plugin - v1 #12092
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonish
requested review from
jufajardini,
victorjulien and
a team
as code owners
jasonish
commented
Nov 6, 2024
jasonish
commented
Nov 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12092 +/- ##
==========================================
- Coverage 83.23% 83.07% -0.17%
==========================================
Files 906 909 +3
Lines 257647 257861 +214
==========================================
- Hits 214458 214214 -244
- Misses 43189 43647 +458
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Information: ERROR: QA failed on SURI_TLPR1_alerts_cmp.
Pipeline 23277 |
|
Please note BuildnDPITLSQUICJson can be removed (removed now in our branch) as it is no longer used since the introduction of ndpi_dpi2json/jb_set_formatted |
jasonish
force-pushed
the
ish/ndpi/plugin/v1
branch
2 times, most recently
from
2952ce7 to
3242b8c
Compare
jasonish
commented
Nov 7, 2024
|
WARNING:
Pipeline 23294 |
jasonish
force-pushed
the
ish/ndpi/plugin/v1
branch
from
3242b8c to
e955132
Compare
|
ERROR: ERROR: QA failed on SURI_TLPR1_alerts_cmp. Pipeline 23317 |
Add documentation about the rule types introduced by 2696fda. Add doc tags around code definitions that are referenced in the docs. Task #https://redmine.openinfosecfoundation.org/issues/7031
To enable ndpi, --enable-ndpi and --with-ndpi=<DIR> must be provided.
jasonish
force-pushed
the
ish/ndpi/plugin/v1
branch
from
e955132 to
8b8c51c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nDPI implemented as a plugin, with some minor fixups by me.