De only/v1 #12217
Closed
De only/v1 #12217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing setup part of the decoder event sgh. Bug: OISF#7414.
Default decoder event alert was very sparse, not even logging packet type and pcap_cnt. Expand support for this record type. It will be more useful with the ethernet headers and packet field, but these are still disabled by default. Ticket: OISF#7433.
victorjulien
commented
Dec 4, 2024
| /* just the timestamp, no tuple */ | ||
| jb_set_string(jb, "timestamp", timebuf); | ||
| /* payload */ | ||
| if (json_output_ctx->flags & |
There was a problem hiding this comment.
this seems useless, as we won't have a payload for this case?
There was a problem hiding this comment.
Not even for the decode-event:ipv6.frag_pkt_too_large kind?
There was a problem hiding this comment.
I think that would put us in the first condition here?
if (PacketIsIPv4(p) || PacketIsIPv6(p)) {
return AlertJson(tv, aft, p);
} else if (p->alerts.cnt > 0) {
return AlertJsonDecoderEvent(tv, aft, p);
}
|
Information: QA ran without warnings. Pipeline 23665 |
|
Replaced by #12221. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://redmine.openinfosecfoundation.org/issues/7414
https://redmine.openinfosecfoundation.org/issues/7433
SV_BRANCH=OISF/suricata-verify#2159