rfc - app-layer gap handling - v4 #2619
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow app-layers to register that they can handle gaps. Instead of sending a "signal" on a gap, send the gap flag on the next segment, the app-layer "dispatcher" will check if the app-layer can handle gaps or not, and abort if they can't, otherwise the data along with a gap flag will be sent to the app-layer. The idea is that the parser can then make the decision on what to do with the gap.
On data check if the gap flag is set. If so, check if the data is at the start of frame. This is pretty easy with DNP3 as there is a start frame byte sequence.
|
See #2660 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requesting comments on this way of handling gaps in the app-layer. DNP3 is a simple case as its based on frames with a start sequence.
There is one stream test case that is broken from these changes tho.
There are ifdef's of older code as I'm still using them for reference.. Hence this is just an RFC.
Prscript: