Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-layer: fix integer warnings #6649

Closed

Conversation

catenacyber
Copy link
Contributor

Link to redmine ticket:
https://redmine.openinfosecfoundation.org/issues/4516

Describe changes:

  • Avoids some warnings about integers : for direction argument of StreamTcpUpdateAppLayerProgress

DRAFT : do not merge

@victorjulien you said :

I would like this to be solved in a different way, more like how its now done on the Rust side: with a direction enum

But C enums are not as good as Rust enums.
So, I am not sure this is a good idea.

For instance, keeping direction = 1 - direction; in this patch (with direction being an enum Direction) does not produce warnings on my setup !

See commit 53aac7f for the alternative

by using an enumeration for Direction
@suricata-qa
Copy link

ERROR: QA failed on report_failure.

ERROR: QA failed on tlpr1_autofp_suri.

Pipeline 5071

@catenacyber
Copy link
Contributor Author

See #7006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants