Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swf-decompression: Disable by default. #8153

Closed

Conversation

cccs-rtmorti
Copy link
Contributor

Add an entry to the upgrade guide noting the change.

Make sure these boxes are signed before submitting your Pull Request -- thank you.

Link to redmine ticket: 5632

Describe changes:

  • Disable swf decompression by default
  • Add entry in upgrade.rst noting the change and linking to the ticket

Since disabling swf decompression by default is actually not related to how we do lzma decompression (#8132), we can separate these changes.

Add an entry to the upgrade guide noting the change.
@catenacyber
Copy link
Contributor

Could you rebase this on latest master please ?
That should at least fix the CI Check Rust...

Looks fine otherwise

@victorjulien
Copy link
Member

Can you reference the ticket in the commit? Ticket: #xxxx. on its own line.

@victorjulien
Copy link
Member

Also, what happens in case the option is not in the yaml at all? Is it disabled then?

@catenacyber
Copy link
Contributor

Also, what happens in case the option is not in the yaml at all? Is it disabled then?

It is indeed disabled, (and always has been probably)

@victorjulien
Copy link
Member

Also, what happens in case the option is not in the yaml at all? Is it disabled then?

It is indeed disabled, (and always has been probably)

Great, thanks.

@cccs-rtmorti
Copy link
Contributor Author

Updated in #8170

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants