Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Question Title and Description #161

Merged
merged 16 commits into from
Jul 18, 2017
Merged

Conversation

WickyNilliams
Copy link
Contributor

What is the context of this PR?

This adds functionality to Quesitonnaire Designer to edit question title, description, and guidance. It also fixes the questionnaire creation flow to create an initial page by default, otherwise there is no page to edit initially. This can be simplified once the API assumes this repsponsibility (see this PR)

How to review

Review code, run tests

@WickyNilliams
Copy link
Contributor Author

Copy link
Contributor

@hamishtaplin hamishtaplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

A few proptype warnings in the console though, as discussed.

Also, the "Builder" link in the nav should link to the first page in the section now we have one.

@hamishtaplin hamishtaplin merged commit 8311228 into master Jul 18, 2017
@hamishtaplin hamishtaplin deleted the 123/question-title-description branch July 18, 2017 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants