core: arm: enable native interrupts before init calls #7262
Conversation
core/arch/arm/kernel/boot.c
Outdated
| @@ -1069,8 +1069,15 @@ void __weak boot_init_primary_late(unsigned long fdt __unused, | |||
|
|
|||
| boot_primary_init_intc(); | |||
| init_vfp_nsec(); | |||
| if (!IS_ENABLED(CFG_NS_VIRTUALIZATION)) | |||
| if (!IS_ENABLED(CFG_NS_VIRTUALIZATION)) { | |||
| if (IS_ENABLED(CFG_UNMASK_NATIVE_INTR_AT_BOOT)) { | |||
There was a problem hiding this comment.
Why not always enable this?
| init_tee_runtime(); | ||
| } |
There was a problem hiding this comment.
We should probably disable the interrupts again since entry_a64.S doesn't expect interrupts to be enabled when boot_init_primary_late() returns.
There was a problem hiding this comment.
Right. Then i'll unmask them back in boot_init_primary_final() for call_driver_initcalls() and call_finalcalls() execution.
| call_driver_initcalls(); | ||
| } | ||
|
|
||
| call_finalcalls(); |
There was a problem hiding this comment.
CFG_NS_VIRTUALIZATION may also benefit from unmasked native interrupts during finalcalls.
There was a problem hiding this comment.
Right, I missed that. Thanks, i'll update.
Enable native interrupts on Arm architectures when executing initcalls (early,service,driver,final). This change allows drivers to leverage interrupts during OP-TEE core initialization, as for example detecting a firewall access violation when it occurs. Before this change, OP-TEE needed to complete its initialization and return the secure monitor for secure interrupts to be handled. Note that when CFG_NS_VIRTUALIZATION is enabled, initcalls called from virt_on_stdcall() is not changed here since they are executing from a standard call entry hence with native and foreign interrupts already default unmasked. Signed-off-by: Etienne Carriere <[email protected]> Reviewed-by: Jens Wiklander <[email protected]>
etienne-lms
force-pushed
the
initcalls-itr
branch
from
1dcae02 to
af7060f
Compare
|
Fixup commits squashed and review tag applied. |
|
I forgot to say that I've changed the commit message body. Please cross-check that it still matches change description expectations. |
|
Looks good. :-) |
Enable native interrupts on Arm architecture before initcalls handlers are called. This change allows drivers to leverage interrupts during OP-TEE core initialization, as for example detecting a firewall access violation when it happens. Before this change, OP-TEE needed to complete its initialization and return the secure monitor for secure interrupts to be handled.
The feature is embedded upon config switch CFG_UNMASK_NATIVE_INTR_AT_BOOT and applies only when CFG_NS_VIRTUALIZATION is disabled. When CFG_NS_VIRTUALIZATION is enabled, early/service/driver initcalls already execute with native interrupts unmasked, from a standard call entry when the non-secure guest is registered.