Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(board-view) : #MAG-233/234 add zoom levels for board view #50

Merged
merged 2 commits into from
Oct 3, 2023
Merged

feat(board-view) : #MAG-233/234 add zoom levels for board view #50

merged 2 commits into from
Oct 3, 2023

Conversation

flmartineau
Copy link
Collaborator

@flmartineau flmartineau commented Oct 3, 2023 •
edited
Loading

Describe your changes

  • added zoom component
  • added handling of multiple zoom levels for the board view

Checklist tests

  • check if the board view is displaying properly in any zoom level
  • check if the zoom level is saved for the current user
  • check card display when comments are off/on and sections are activated or not
  • check if the view is responsive

Issue ticket number and link

https://jira.support-ent.fr/browse/MAG-233
https://jira.support-ent.fr/browse/MAG-234

Checklist before requesting a review (magic string, indentation, comment/documentation...)

  • I have detailed the tests to do in my feature/fix in order to prevent consequents regressions (must specify in Checklist tests)
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (API Doc etc...) - (must specify in Description for target version)
  • If it is a consequent feature, I have added thorough tests.
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been added to this project (must specify in Description)

@flmartineau flmartineau merged commit 41c9123 into dev Oct 3, 2023
0 of 2 checks passed
@flmartineau flmartineau deleted the MAG-233 branch October 3, 2023 15:36
flmartineau added a commit that referenced this pull request Oct 3, 2023
@flmartineau @Rseuret
feat(board-view) : #MAG-233/234 add zoom levels for board view (#50)
70ff611 
* feat(zoom) #MAG-234 : add zoom component for board view

* feat(board): #MAG-233 adapt board CSS for zoom levels

---------

Co-authored-by: rseuret <[email protected]>
Sofianebernoussi pushed a commit that referenced this pull request Oct 5, 2023
@flmartineau @Rseuret
feat(board-view) : #MAG-233/234 add zoom levels for board view (#50)
f836440 
* feat(zoom) #MAG-234 : add zoom component for board view

* feat(board): #MAG-233 adapt board CSS for zoom levels

---------

Co-authored-by: rseuret <[email protected]>
Sofianebernoussi pushed a commit that referenced this pull request Oct 5, 2023
@flmartineau @Rseuret
feat(board-view) : #MAG-233/234 add zoom levels for board view (#50)
c322ccc 
* feat(zoom) #MAG-234 : add zoom component for board view

* feat(board): #MAG-233 adapt board CSS for zoom levels

---------

Co-authored-by: rseuret <[email protected]>
Sofianebernoussi pushed a commit that referenced this pull request Oct 5, 2023
@flmartineau @Rseuret
feat(board-view) : #MAG-233/234 add zoom levels for board view (#50)
1efaeab 
* feat(zoom) #MAG-234 : add zoom component for board view

* feat(board): #MAG-233 adapt board CSS for zoom levels

---------

Co-authored-by: rseuret <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sofianebernoussi Sofianebernoussi Sofianebernoussi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flmartineau @Sofianebernoussi @Rseuret