Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shapelib Building with RENAME_INTERNAL_SHAPELIB_SYMBOLS=OFF causes compile error #8532

Closed
OlekRaymond opened this issue Oct 9, 2023 · 2 comments
Closed

Shapelib Building with RENAME_INTERNAL_SHAPELIB_SYMBOLS=OFF causes compile error #8532

OlekRaymond opened this issue Oct 9, 2023 · 2 comments
Assignees
@rouault
Milestone
3.7.3

Comments

@OlekRaymond
Copy link

Expected behaviour and actual behaviour.

When building GDAL using CMake and requesting that shapelib functions NOT be renamed a compilation failure occurs.

Steps to reproduce the problem.

using cmake.exe -DGDAL_USE_INTERNAL_LIBS=WHEN_NO_EXTERNAL -DRENAME_INTERNAL_SHAPELIB_SYMBOLS=OFF .\ results in the compiler error when building

Operating system

Windows 10 Pro (22H2)
64-bit operating system, x64-based processor
Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz 1.99 GHz

GDAL version and provenance

Issue is in 3.5.3 - 3.7.2

Credit to Russell Mills from Riskaware LTD for finding the issue.
@rouault rouault self-assigned this Oct 9, 2023
@rouault
Copy link
Member

rouault commented Oct 9, 2023

fixed per d7ab108 . backport to 3.7 per bbba4fe

@rouault rouault closed this as completed Oct 9, 2023
@rouault rouault added this to the 3.7.3 milestone Oct 9, 2023
rouault added a commit that referenced this issue Oct 9, 2023
@rouault
Shape: fix build with -DRENAME_INTERNAL_SHAPELIB_SYMBOLS=OFF (fixes #…
d7ab108 
…8532)
rouault added a commit that referenced this issue Oct 9, 2023
@rouault
Shape: fix build with -DRENAME_INTERNAL_SHAPELIB_SYMBOLS=OFF (fixes #…
bbba4fe 
…8532)
@OlekRaymond
Copy link
Author

Thanks 😄

bradh pushed a commit to bradh/gdal that referenced this issue Oct 22, 2023
@rouault @bradh
Shape: fix build with -DRENAME_INTERNAL_SHAPELIB_SYMBOLS=OFF (fixes O…
edffd5a 
…SGeo#8532)
@JustCallMeRay JustCallMeRay mentioned this issue Sep 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rouault rouault

Labels
None yet
Projects
None yet
Milestone
3.7.3
Development

No branches or pull requests
2 participants
@rouault @OlekRaymond