Fixed handling of oem reboot settings #2055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidcassany would be great if you find the time to look at this change. It's initrd code you know it's mean and always strikes back :) Thanks much. I also set the WIP label as I wanted to test it extensively before merge |
schaefi
force-pushed
the
fix_oem_reboot
branch
from
37e7e50 to
e4c775c
Compare
davidcassany
approved these changes
Feb 7, 2022
There are oem settings called oem-reboot, oem-reboot-interactive as well as oem-shutdown and oem-shutdown-interactive. When used the information is passed along to the profile but not evaluated by any initrd code. I don't know where on the way we lost the code that actually works with these settings but this commit makes them effective. This Fixes #2056
schaefi
force-pushed
the
fix_oem_reboot
branch
from
e4c775c to
1cde1e6
Compare
|
@davidcassany Thanks for looking at it. I have done some tests and it worked in the desired way. I will merge this as soon as the tests passes |
This was referenced Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are oem settings called oem-reboot, oem-reboot-interactive
as well as oem-shutdown and oem-shutdown-interactive. When used
the information is passed along to the profile but not evaluated
by any initrd code. I don't know where on the way we lost the
code that actually works with these settings but this commit
makes them effective.