Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add master/replica service to redis replication #1124

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

drivebyer
Copy link
Collaborator

Description

#765
#777
#785

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

@drivebyer drivebyer added the enhancement New feature or request label Nov 11, 2024
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 63 lines in your changes missing coverage. Please review.

Project coverage is 44.12%. Comparing base (d121d86) to head (c483aa5).
Report is 131 commits behind head on master.

Files with missing lines Patch % Lines
pkg/k8sutils/redis-replication.go 0.00% 23 Missing ⚠️
pkg/k8sutils/redis-sentinel.go 0.00% 11 Missing ⚠️
pkg/k8sutils/redis-standalone.go 0.00% 11 Missing ⚠️
pkg/k8sutils/redis-cluster.go 0.00% 9 Missing and 1 partial ⚠️
pkg/util/map.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1124      +/-   ##
==========================================
+ Coverage   35.20%   44.12%   +8.92%     
==========================================
  Files          19       21       +2     
  Lines        3213     3431     +218     
==========================================
+ Hits         1131     1514     +383     
+ Misses       2015     1830     -185     
- Partials       67       87      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer drivebyer merged commit 147d706 into OT-CONTAINER-KIT:master Nov 11, 2024
18 of 19 checks passed
@drivebyer drivebyer deleted the replication-service branch November 11, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant