-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: redis-cluster add podAntiAffinity(#1174 ) #1180
feat: redis-cluster add podAntiAffinity(#1174 ) #1180
Conversation
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: xiaozhuang <[email protected]>
webhook MutatingWebhookConfiguration need to add it to the redis-operator charts template? |
Signed-off-by: xiaozhuang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1180 +/- ##
==========================================
- Coverage 30.20% 29.70% -0.51%
==========================================
Files 55 57 +2
Lines 6294 6579 +285
==========================================
+ Hits 1901 1954 +53
- Misses 4200 4440 +240
+ Partials 193 185 -8 ☔ View full report in Codecov by Sentry. |
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: xiaozhuang <[email protected]>
Nice idea. How about trigger mutation by adding an annotation to the RedisCluster resource, such as rediscluster.redis.redis.opstreelabs.in/role-anti-affinity. @xiaozhuang-a |
BTW, we need add some test case to it. |
I think the 'add annotation' solution is very good, and I will implement it |
get |
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: xiaozhuang <[email protected]>
d1f64d6
to
46abdd1
Compare
Signed-off-by: xiaozhuang <[email protected]>
bbecbb7
to
93b5f56
Compare
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
support leader and follower anti affinity of pods with the same order
Fixes #ISSUE
Type of change
Checklist
Additional Context