Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redis-cluster add podAntiAffinity(#1174 ) #1180

Merged
merged 14 commits into from
Dec 27, 2024

Conversation

xiaozhuang-a
Copy link
Contributor

Description

support leader and follower anti affinity of pods with the same order

Fixes #ISSUE

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

xiaozhuang added 3 commits December 20, 2024 19:00
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: xiaozhuang <[email protected]>
@xiaozhuang-a
Copy link
Contributor Author

webhook MutatingWebhookConfiguration need to add it to the redis-operator charts template?

Signed-off-by: xiaozhuang <[email protected]>
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 63.82979% with 34 lines in your changes missing coverage. Please review.

Project coverage is 29.70%. Comparing base (60ef5a2) to head (858fb42).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
pkg/webhook/pod_webhook.go 65.21% 24 Missing and 8 partials ⚠️
main.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
- Coverage   30.20%   29.70%   -0.51%     
==========================================
  Files          55       57       +2     
  Lines        6294     6579     +285     
==========================================
+ Hits         1901     1954      +53     
- Misses       4200     4440     +240     
+ Partials      193      185       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drivebyer
Copy link
Collaborator

drivebyer commented Dec 21, 2024

Nice idea.

How about trigger mutation by adding an annotation to the RedisCluster resource, such as rediscluster.redis.redis.opstreelabs.in/role-anti-affinity. @xiaozhuang-a

@drivebyer
Copy link
Collaborator

BTW, we need add some test case to it.

@xiaozhuang-a
Copy link
Contributor Author

Nice idea.

How about trigger mutation by adding an annotation to the RedisCluster resource, such as rediscluster.redis.redis.opstreelabs.in/role-anti-affinity. @xiaozhuang-a

I think the 'add annotation' solution is very good, and I will implement it

@xiaozhuang-a
Copy link
Contributor Author

BTW, we need add some test case to it.

get

xiaozhuang added 2 commits December 26, 2024 21:18
Signed-off-by: xiaozhuang <[email protected]>
xiaozhuang and others added 4 commits December 26, 2024 23:00
Signed-off-by: xiaozhuang <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer enabled auto-merge (squash) December 27, 2024 06:44
Copy link
Collaborator

@drivebyer drivebyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drivebyer drivebyer merged commit bf1c79f into OT-CONTAINER-KIT:master Dec 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants