Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance Redis HA and node scheduling strategy #1237

Merged
merged 9 commits into from
Feb 7, 2025

Conversation

drivebyer
Copy link
Collaborator

  • Updated e2e test to simulate node shutdown instead of pod deletion
  • Added pod anti-affinity configuration for Redis replication and sentinel nodes
  • Removed unnecessary StatefulSet readiness check in Redis replication controller
  • Improved node scheduling to distribute Redis pods across different worker nodes

Description

Fixes #1217 #1231

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • Tests have been added/modified and all tests pass.
  • Functionality/bugs have been confirmed to be unchanged or fixed.
  • I have performed a self-review of my own code.
  • Documentation has been updated or added where necessary.

Additional Context

- Updated e2e test to simulate node shutdown instead of pod deletion
- Added pod anti-affinity configuration for Redis replication and sentinel nodes
- Removed unnecessary StatefulSet readiness check in Redis replication controller
- Improved node scheduling to distribute Redis pods across different worker nodes

Signed-off-by: drivebyer <[email protected]>
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.06%. Comparing base (60ef5a2) to head (493df1a).
Report is 42 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1237      +/-   ##
==========================================
- Coverage   30.20%   29.06%   -1.15%     
==========================================
  Files          55       58       +3     
  Lines        6294     6693     +399     
==========================================
+ Hits         1901     1945      +44     
- Misses       4200     4586     +386     
+ Partials      193      162      -31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
Signed-off-by: drivebyer <[email protected]>
@drivebyer drivebyer merged commit f7e9204 into OT-CONTAINER-KIT:master Feb 7, 2025
18 of 19 checks passed
@drivebyer drivebyer added the enhancement New feature or request label Feb 7, 2025
@drivebyer drivebyer deleted the ha branch February 8, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis Sentinel Failover Issues: Outdated Master Info and New Master Pod Label Not Updated
1 participant