Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add Redis Sentinel Support #408

Merged
merged 18 commits into from
Feb 13, 2023
Merged

[Feature] Add Redis Sentinel Support #408

merged 18 commits into from
Feb 13, 2023

Conversation

shubham-cmyk
Copy link
Member

@shubham-cmyk shubham-cmyk commented Jan 9, 2023 •
edited
Loading

Redis Sentinel Mode Is now supported
Add your redis-replication name to the field

  redisSentinelConfig: 
    redisReplicationName : redis-replication

@shubham-cmyk shubham-cmyk mentioned this pull request Feb 12, 2023
Closed
@shubham-cmyk shubham-cmyk mentioned this pull request Feb 12, 2023
Closed
iamabhishek-dubey
iamabhishek-dubey approved these changes Feb 13, 2023
View reviewed changes
api/v1beta1/redissentinel_types.go Outdated Show resolved Hide resolved
api/v1beta1/redissentinel_types.go Show resolved Hide resolved
controllers/redissentinel_controller.go Show resolved Hide resolved
example/redis_sentinel/sentinel.yaml Outdated Show resolved Hide resolved
k8sutils/redis-sentinel.go Outdated Show resolved Hide resolved
This was linked to issues Feb 13, 2023
Hope to support redis sentinel mode #146
Closed
Is is possible to Create a Redis Cluster with 2 Replicas #185
Closed
@iamabhishek-dubey iamabhishek-dubey merged commit e86884e into OT-CONTAINER-KIT:master Feb 13, 2023
@shubham-cmyk shubham-cmyk deleted the sentinel branch February 14, 2023 19:15
@muicoder
Copy link
Contributor

Error: initializing source docker://quay.io/opstree/redis-sentinel:v7.0.7: reading manifest v7.0.7 in quay.io/opstree/redis-sentinel: unauthorized: access to the requested resource is not authorized

@shubham-cmyk
Copy link
Member Author

@muicoder We have not released helm we would do it today

@lapete
Copy link

lapete commented Feb 20, 2023

Hi, I still can't pull the sentinel chart from quay.io nor find it in https://github.com/OT-CONTAINER-KIT/helm-charts/tree/main/charts
Is it not released yet or am I doing something wrong?
Failed to pull image "quay.io/opstree/redis-sentinel:v7.0.7": rpc error: code = Unknown desc = failed to pull and unpack image "quay.io/opstree/redis-sentinel:v7.0.7": failed to resolve reference "quay.io/opstree/redis-sentinel:v7.0.7": pulling from host quay.io failed with status code [manifests v7.0.7]: 401 UNAUTHORIZED
I'm on operator 0.14 and used the example code from this repo.

@muicoder
Copy link
Contributor

muicoder commented Feb 20, 2023 •
edited
Loading

Hi, I still can't pull the sentinel chart from quay.io nor find it in https://github.com/OT-CONTAINER-KIT/helm-charts/tree/main/charts
Is it not released yet or am I doing something wrong?
Failed to pull image "quay.io/opstree/redis-sentinel:v7.0.7": rpc error: code = Unknown desc = failed to pull and unpack image "quay.io/opstree/redis-sentinel:v7.0.7": failed to resolve reference "quay.io/opstree/redis-sentinel:v7.0.7": pulling from host quay.io failed with status code [manifests v7.0.7]: 401 UNAUTHORIZED
I'm on operator 0.14 and used the example code from this repo.

You can experience this chart first:

Tested for Chart

muicoder/redis-operator@master...action

devkmsg added a commit to devkmsg/redis-operator that referenced this pull request Mar 7, 2023
@devkmsg
Merge pull request OT-CONTAINER-KIT#11 in OSS/redis-operator from ~AT…
4a664bd 
…HOMPSON/redis-operator:sync-upstream-0.14 to master

Auto-Merge: Pull request OT-CONTAINER-KIT#11: [AUTO] Sync upstream @ v0.14

Merge in OSS/redis-operator from ~ATHOMPSON/redis-operatorsync-upstream-0.14 to master

* commit 'e86884ead1005484bdb10fb30caf8f8acac2f89b': (49 commits)
  [Feature] Add Redis Sentinel Support  (OT-CONTAINER-KIT#408)
  Fixed Redis Replicate Cache bug (OT-CONTAINER-KIT#424)
  [Feature] : Add Replication Mode to the Redis Operator (OT-CONTAINER-KIT#417)
  [Development][Add] Added recreation logic for statefulset (OT-CONTAINER-KIT#411)
  Fixes issue with arm64 support. (OT-CONTAINER-KIT#404)
  [Development][Add] Added nodeSelector and tolerations for cluster (OT-CONTAINER-KIT#410)
  Add Label Selector to pod anti affinity  (OT-CONTAINER-KIT#407)
  When cr annotation update,sts annotations will not updated! (OT-CONTAINER-KIT#398)
  fix: invalid memory address or nil pointer dereference (OT-CONTAINER-KIT#395)
  export redis exporter as a container port (OT-CONTAINER-KIT#393)
  [Development][Add] Added feature for additional volume mounts (OT-CONTAINER-KIT#389)
  fix crash with go panic (OT-CONTAINER-KIT#385)
  Add check PersistenceEnabled not nil (OT-CONTAINER-KIT#380)
  [feature]add serviceType functionality for standalone and cluster with annotations (OT-CONTAINER-KIT#376)
  [Development][Update]Updated information for v0.13.0 (OT-CONTAINER-KIT#374)
  Create CODE_OF_CONDUCT.md
  [feature]add tls for redis-standlone (OT-CONTAINER-KIT#372)
  Update README.md
  Create package.json
  Revamped documentation for better knowledge base (OT-CONTAINER-KIT#370)
  ...
@shubham-cmyk
Copy link
Member Author

shubham-cmyk commented Mar 7, 2023 •
edited
Loading

@lapete Helm Chart was released sorry to tag you later

@lapete
Copy link

lapete commented Mar 8, 2023

Thanks, I noticed already and am using it. :) Just waiting for the Exporter being merged now, I've seen there's a PR already

@shubham-cmyk
Copy link
Member Author

shubham-cmyk commented Mar 8, 2023 •
edited
Loading

It would be merged soon once the redis cluster scaling on runtime PR is merged.
@lapete

@lapete
Copy link

lapete commented Mar 8, 2023

That's great news, thanks for letting me know.

devkmsg added a commit to devkmsg/redis-operator that referenced this pull request Jan 30, 2024
@devkmsg
Pull request OT-CONTAINER-KIT#12: Sync our internal branch to v0.14 w…
8b233c9 
…/internal patches

Merge in OSS/redis-operator from ~ATHOMPSON/redis-operator:sync-internal-cs-main-to-0.14 to cs-main

* commit '2ea8fcaf61b322186f8a0a2c4e7bcb310f55ea2d':
  Revert "Handle nil probe"
  Handle nil probe
  Bumps prometheus/client_golang to address vuln
  Adds CODEOWNERS for our internal branch
  [Feature] Add Redis Sentinel Support  (OT-CONTAINER-KIT#408)
  Fixed Redis Replicate Cache bug (OT-CONTAINER-KIT#424)
  [Feature] : Add Replication Mode to the Redis Operator (OT-CONTAINER-KIT#417)
  [Development][Add] Added recreation logic for statefulset (OT-CONTAINER-KIT#411)
  Fixes issue with arm64 support. (OT-CONTAINER-KIT#404)
  [Development][Add] Added nodeSelector and tolerations for cluster (OT-CONTAINER-KIT#410)
  Add Label Selector to pod anti affinity  (OT-CONTAINER-KIT#407)
  When cr annotation update,sts annotations will not updated! (OT-CONTAINER-KIT#398)
  fix: invalid memory address or nil pointer dereference (OT-CONTAINER-KIT#395)
  export redis exporter as a container port (OT-CONTAINER-KIT#393)
  [Development][Add] Added feature for additional volume mounts (OT-CONTAINER-KIT#389)
  fix crash with go panic (OT-CONTAINER-KIT#385)
  Add check PersistenceEnabled not nil (OT-CONTAINER-KIT#380)
  [feature]add serviceType functionality for standalone and cluster with annotations (OT-CONTAINER-KIT#376)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamabhishek-dubey iamabhishek-dubey iamabhishek-dubey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is is possible to Create a Redis Cluster with 2 Replicas Hope to support redis sentinel mode
4 participants
@shubham-cmyk @muicoder @lapete @iamabhishek-dubey