Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code-quality checks due to compute time & added binary-checks on other scripts #71

Merged
merged 4 commits into from
Nov 24, 2021

Conversation

commjoen
Copy link
Collaborator

Thank you for submitting a pull request to the WrongSecrets app!

Copy link
Collaborator

@bendehaan bendehaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the vault binary actually necessary?

aws/k8s-vault-aws-start.sh Outdated Show resolved Hide resolved
gcp/k8s-vault-gcp-start.sh Outdated Show resolved Hide resolved
@commjoen
Copy link
Collaborator Author

Is the vault binary actually necessary?

yes ;( as we use vault to put values in... we could replace it with curl in the future, but rather just go with the flow now.

@commjoen commjoen requested a review from bendehaan November 24, 2021 10:42
@commjoen commjoen merged commit 092db62 into master Nov 24, 2021
@commjoen commjoen deleted the pre-requisites branch November 24, 2021 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants