Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Azure support #97

Merged
merged 17 commits into from
Jan 11, 2022
Merged

Add Azure support #97

merged 17 commits into from
Jan 11, 2022

Conversation

bendehaan
Copy link
Collaborator

@bendehaan bendehaan commented Dec 6, 2021 •
edited
Loading

Thank you for submitting a pull request to the WrongSecrets app!

Closes #93

@bendehaan bendehaan force-pushed the feature/azure branch 3 times, most recently from 9f7e00a to 7103104 Compare January 5, 2022 10:44
@bendehaan bendehaan changed the title Draft: Add WIP Azure support Draft: Add Azure support Jan 5, 2022
@bendehaan bendehaan marked this pull request as ready for review January 10, 2022 16:04
@bendehaan bendehaan changed the title Draft: Add Azure support Add Azure support Jan 10, 2022
@bendehaan bendehaan requested review from commjoen and nbaars January 10, 2022 18:00
commjoen
commjoen requested changes Jan 10, 2022
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great starting point! Have a few review comments and will test it further tomorrow.
BTW: already refactored java a little so it would have less repetition, but not sure about the name of the method introdcued.

bendehaan and others added 17 commits January 11, 2022 10:01
@bendehaan
Add WIP Azure
4062920
@bendehaan
Clean up volume template file
a907da9
@bendehaan
Use OWASP resource group by default
fc7b984
@bendehaan
Add Azure conf without role assignments
a133aa3
@bendehaan
Add non-working java for challenge 11
4cd1a6f
@bendehaan
Fix Java issue and update explanation
ad89137
@bendehaan
Fix checkstyle errors
a6dd17f
@bendehaan
Update documentation link
540d3b7
@bendehaan
Non-tested support for azure challenge 11
b847bc4
@bendehaan
Working version of Azure 9 and 10
88c41d0
@bendehaan
Add support for Azure challenge 11 and fix hints/reasons
41fc7dc
@commjoen @bendehaan
reduce code repetition
3e4b41a
@commjoen @bendehaan
cleanup unused imports
b4211fd
@bendehaan
Explicitly set Key Vault purge protection and soft delete
0abc0e4
@bendehaan @commjoen
Update src/main/resources/explanations/challenge11-azure.adoc
82494ca 
Co-authored-by: Jeroen Willemsen <[email protected]>
@bendehaan
Add log statement for default Azure case
ebacf98
@bendehaan
Replace gcp for azure in challenge explanation
301b779
@bendehaan bendehaan requested a review from commjoen January 11, 2022 09:02
commjoen
commjoen approved these changes Jan 11, 2022
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! seriously good enough for an RC1 release :) of 1.3.0

@commjoen commjoen merged commit 1e96931 into master Jan 11, 2022
@commjoen commjoen deleted the feature/azure branch January 11, 2022 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen commjoen approved these changes

@nbaars nbaars Awaiting requested review from nbaars

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure support
2 participants
@bendehaan @commjoen