Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EM Search Attributes Integration #17

Open
marcelolz opened this issue Sep 12, 2020 · 3 comments
Open

EM Search Attributes Integration #17

marcelolz opened this issue Sep 12, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@marcelolz
Copy link

This plugin is very promising. For now, however, I tried to display only the events of the current user with: owner = "USER_ID". But it didn't work. Is this something that you think about dealing with in the future or is there something already in that direction?

Muito obrigado!

@Gustl22
Copy link
Collaborator

Gustl22 commented Sep 15, 2020

I think WP FullCalendar didn't offer this tag, so didn't think of implementing anything like that. You may can explain the use case in more detail. I would also be happy to review a Merge-Request.
Sorry for the late response, I'm in vacation right now :)

@Gustl22 Gustl22 self-assigned this Oct 7, 2020
@Gustl22 Gustl22 added the enhancement New feature or request label Oct 7, 2020
@Gustl22
Copy link
Collaborator

Gustl22 commented Oct 7, 2020

Hey @marcelolz, I had a deeper look in the issue.

I think you want to make the Search attributes of Events Manager work again in this plugin.
Indeed the extra params are not yet transmitted via the fetch / ajax call, which was possible in the former WP FullCalendar plugin. But the most Request params are overwritten unfortunately, which have to be reenabled / rewritten in the wpfc_fullcalendar_args-Hook.
So I think, there may can occur security concerns, so we may have to ask the EM developers, why the array is overwritten here.

Related (unanswered) topics:
https://wordpress.org/support/topic/shortcode-filter-by-tag/
https://wordpress.org/support/topic/owner-parameter-doesnt-work-on-shortcode/

But I try to update this version, to at least pass the other search parameters written in the shortcode to Events-Manager API.

@Gustl22
Copy link
Collaborator

Gustl22 commented Oct 7, 2020

I fixed part of the issue in c3c7fe4. You may want to test this before merging. Note that this only will work if it already worked for WP FullCalendar (e.g. with help of wpfc_fullcalendar_args ).

gb-fullcalendar-17-em-search-attributes-SNAPSHOT.zip

@Gustl22 Gustl22 changed the title Events of user actual EM Search Attributes Integration Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants