-
-
Notifications
You must be signed in to change notification settings - Fork 69
Conversation
@VolCh please also add the phpcs checks to |
You can gladly bump to 7.2 FWIW
…On Sat, 12 May 2018, 12:13 Vladimir Chernyshev, ***@***.***> wrote:
@Ocramius <https://github.com/Ocramius> should we maintain PHP 7.0
compatible or I shall take in mind #74
<#74> with PHP 7.1 at
least?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#77 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakO2rd4jRkNNKTSmFE9TBEOOkJlhXks5txrXhgaJpZM4T6a1C>
.
|
@Ocramius I renamed classes
Also i'm not sure that |
@Ocramius is this PR acceptable now? |
*/ | ||
class HydratorGenerator implements HydratorGeneratorInterface | ||
interface HydratorGenerator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this is a major BC break: would have preferred an exclusion rule, but let's roll with it
Requires a rebase, but otherwise good to go by me 👍 |
…Comment.MultiLinePropertyComment
…0 compatible level)
d04c248
to
38f464f
Compare
Done. Also fixed few |
👍 thanks! |
I don't suppose we could keep the library to php 7.1 for release When I trialled #79 I had to go to the |
@redthor I bump my dependency versions regularly anyway: using an older stable version of the library is perfectly OK. |
namespace GeneratedHydratorBenchmark; | ||
|
||
/** | ||
* Class that contains only private properties | ||
*/ | ||
class AllPrivateClass | ||
{ | ||
//phpcs:disable SlevomatCodingStandard.Classes.UnusedPrivateElements.UnusedProperty |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say it's preferable to do file-level excludes in phpcs.xml.dist rather than using inline comments.
Renamed in /src:
\GeneratedHydratorBenchmark\{HydrationBenchInterface -> HydrationBench}
\GeneratedHydrator\ClassGenerator\{HydratorGeneratorInterface -> HydratorGenerator}
\GeneratedHydrator\ClassGenerator\{HydratorGenerator -> DefaultHydratorGenerator}
\GeneratedHydrator\Exception\{ExceptionInterface -> Exception}
\GeneratedHydrator\Exception\{DisabledMethodException::desabledMethod ->DisabledMethod::create}