[wip] start implement #64 #78

VolCh · 2018-06-13T15:49:17Z

Fixes #64

VolCh · 2019-12-10T12:49:04Z

src/GeneratedHydrator/ClosureGenerator/FileCache/GenerateFileCacheHydrator.php

+    public function __invoke(string $className) : callable
+    {
+        if (isset(self::$hydratorsCache[$className])) {
+            return self::$hydratorsCache[$className];
+        }
+
+        // @todo Use modern PSR folder structure?
+        $filename = $this->targetDir . str_replace('\\', '_', $className) . '.php';
+        if (! file_exists($filename)) {
+            $this->generateFile($className, $filename);
+        }
+        $generateHydrator = $this;
+
+        $hydrate = require $filename;
+
+        return self::$hydratorsCache[$className] = $hydrate;
+    }


I need feedback about this piece of code and generated code

VolCh · 2019-12-10T12:51:37Z

I've been back.

This PR is definitely not ready for merge now but I need feedback about GeneratedHydrator\ClosureGenerator\FileCache\GenerateFileCacheHydrator:__invoke() method and the generated code principles.

malukenho added the enhancement label Jun 14, 2018

VolCh added 2 commits December 7, 2019 17:14

Initial implementation of closure GenerateExtractor & GenerateHydrator

e239a98

Structurize benchmarks

479aacd

VolCh force-pushed the closure branch from eeb8b55 to 47b0396 Compare December 10, 2019 07:04

VolCh added 2 commits December 10, 2019 09:14

Add benchmarks for runtime closure hydrator

c352aef

Add file cache closure hydrator

55b01e4

VolCh force-pushed the closure branch from 47b0396 to 55b01e4 Compare December 10, 2019 07:15

VolCh commented Dec 10, 2019

View reviewed changes

Ocramius changed the base branch from master to 4.2.x January 17, 2021 19:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wip] start implement #64 #78

[wip] start implement #64 #78

VolCh commented Jun 13, 2018 •

edited by Ocramius

Loading

VolCh Dec 10, 2019

VolCh commented Dec 10, 2019

[wip] start implement #64 #78

Are you sure you want to change the base?

[wip] start implement #64 #78

Conversation

VolCh commented Jun 13, 2018 • edited by Ocramius Loading

VolCh Dec 10, 2019

Choose a reason for hiding this comment

VolCh commented Dec 10, 2019

VolCh commented Jun 13, 2018 •

edited by Ocramius

Loading