Skip to content
This repository has been archived by the owner on Mar 26, 2019. It is now read-only.

Commit

Permalink
Update the CDN references in the README
Browse files Browse the repository at this point in the history
  • Loading branch information
Mike Wheaton committed Nov 21, 2016
1 parent 2e356be commit 59fe160
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ If you'd like to get Fabric through a package manager such as Bower, npm, or NuG
Include the following references in the `<head>` of your page:

```html
<link rel="stylesheet" href="https://appsforoffice.microsoft.com/fabric/fabric-core/4.0.0/fabric.min.css">
<link rel="stylesheet" href="https://appsforoffice.microsoft.com/fabric/fabric-js/1.0.0/fabric.components.min.css">
<link rel="stylesheet" href="https://static2.sharepointonline.com/files/fabric/office-ui-fabric-core/5.0.1/css/fabric.min.css">
<link rel="stylesheet" href="https://static2.sharepointonline.com/files/fabric/office-ui-fabric-js/1.2.0/css/fabric.components.min.css">
```

**Note:** You may notice an additional reference to the Fabric Core - this is intentional as these styles are almost always needed for experiences where you'd like to use the components, so we recommend including it by default.
Expand Down

2 comments on commit 59fe160

@nero120
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mikewheaton, just in case you missed it, the info in the readme header conflicts with this change. It states that the latest version is Fabric JS 1.2.0, which uses Fabric Core 4.0.0 (when CDN is referencing 5.0.1), and the latest version on CDN is Fabric JS 1.0.0 (should be 1.2.0), which uses Fabric Core 4.0.0 (should be 5.0.1). Cheers.

@mikewheaton
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @nero120, we're working on a new pull request now to get this all straightened out. 😄

Please sign in to comment.