This repository has been archived by the owner on Mar 26, 2019. It is now read-only.
Fixes for #63, #187 and tab index changes #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tabindex. Fixed documentation bug. Moved handler bindings to constructor.
wdo3650
changed the title
|
Approved |
1 similar comment
|
Approved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Removed tab index parameter from addItem method in favor of automatic incrementing the tab index. Also tab index was being output to 0 if no tab index was entered which this fixes.
-Fixed bug in documentation, #187, where the component wasn't being initialized in Javascript
-Replaced 'string' with 'number' in code comment documentation for removeItemByPosition
-Earlier update fixes undefined href bug noted in #63