This repository has been archived by the owner on Mar 26, 2019. It is now read-only.
JS Site bug fixes #269
Merged
JS Site bug fixes #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der nav #296002 Fabric JS Website Bug: SearchBox z-index issues #295990 Fabric JS Website Bug: Copyright banner in the HTML
…React ChoiceGroup
…ea" does not dismiss left nav
#296008 Fabric JS Website Bug: Persona initials variant needs to be capitalized
… doesn't work in Firefox
…ponent renders outside the page
…rectly in Firefox
mikewheaton
approved these changes
Jan 11, 2017
|
Approved |
Jahnp
approved these changes
Jan 11, 2017
| text-align: center; | ||
|
|
||
|
|
There was a problem hiding this comment.
Small nit, but is there a reason for this extra whitespace? If not I'd probably take it out.
| } | ||
|
|
||
|
|
||
| .ms-TableData { | ||
| tbody { | ||
| td { |
There was a problem hiding this comment.
nit: since there's just one property change, rather than nesting, this selector could be shortened to tbody td {...}
gokunymbus
suggested changes
Jan 12, 2017
| @@ -203,7 +208,7 @@ | |||
| pageNavLinks[i].addEventListener("click", scrollToLink) | |||
| } | |||
|
|
|||
| const CONTAINER = $('body'); | |||
| const CONTAINER = $('body, html'); | |||
There was a problem hiding this comment.
We shouldnt be using jQuery at all actually. Can we use
document.querySelectorAll('body, html');
| @@ -11,7 +11,7 @@ $od-Header-bannerWidth: 1300px; | |||
| right: 0; | |||
| top: 0; | |||
| width: 100%; | |||
| z-index: 9; | |||
| z-index: 12; | |||
There was a problem hiding this comment.
We should probably be using the Fabric z-index classes.
// Base Layer Variables
$ms-zIndex-0: 0 !default;
$ms-zIndex-1: 100 !default;
$ms-zIndex-2: 200 !default;
$ms-zIndex-3: 300 !default;
$ms-zIndex-4: 400 !default;
$ms-zIndex-5: 500 !default;
// Base Layer Modifier Variables
$ms-zIndex-back: 0 !default;
$ms-zIndex-middle: 5 !default;
$ms-zIndex-front: 10 !default;
| @@ -2,7 +2,7 @@ | |||
| .pageHeader { | |||
| @include fullWidth(); | |||
| position: relative; | |||
| z-index: 6; | |||
| z-index: 11; | |||
| <li><a href="http://msdn.microsoft.com/en-US/cc300389" target="_blank">Terms of use</a></li> | ||
| <li><a href="http://www.microsoft.com/library/toolbar/3.0/trademarks/en-us.mspx" target="_blank">Trademarks</a></li> | ||
| </ul> | ||
| <div class="od-OfficeFooter-microsoft"> | ||
| <img src="{{relativePath}}images/logo-microsoft.png" width="123" height="24" alt="Microsoft logo" /> | ||
| <div>© 2016 Microsoft</div> | ||
| <div>© 2017 Microsoft</div> |
There was a problem hiding this comment.
Let's make our lives easier and use.
new Date().getFullYear()
There was a problem hiding this comment.
How often does the year change, really? Every couple of years? Seems like an over-optimization.
gokunymbus
approved these changes
Jan 12, 2017
|
Approved |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation bug fixes