Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default filetype mappings #502

Merged
merged 2 commits into from
Jun 11, 2023
Merged

Disable default filetype mappings #502

merged 2 commits into from
Jun 11, 2023

Conversation

russtoku
Copy link
Contributor

@russtoku russtoku commented Jun 6, 2023

On 06/04/23, @nmkip asked on Discord::

Is there a way to disable all the default mappings in one line or do I have to go one by one?

This PR adds an option to disable all of the default mappings for the clients listed in g:conjure#filetypes.

I hope I didn't misunderstand what was wanted.

Copy link
Owner

@Olical Olical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thank you very much for doing this! Just one small style comment (if -> when) but otherwise great.

fnl/conjure/mapping.fnl Show resolved Hide resolved
lua/conjure/client/guile/socket.lua Show resolved Hide resolved
@russtoku
Copy link
Contributor Author

russtoku commented Jun 7, 2023

BTW, I forgot to mention that I arbitrarily chose conjure#mapping#enable_ft_mappings and am not terribly wedded to it. Please choose something that better aligns with your liking.

@Olical Olical merged commit f591977 into Olical:develop Jun 11, 2023
@Olical
Copy link
Owner

Olical commented Jun 11, 2023

Thanks a lot! I like the name, it's as good as any and I'd only pick something similar. Just a colour of a bike shed really 😄 much appreciated!

@russtoku russtoku deleted the dev4 branch July 8, 2023 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants