Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support luarocks/rocks.nvim #579

Merged
merged 1 commit into from
May 24, 2024
Merged

feat: support luarocks/rocks.nvim #579

merged 1 commit into from
May 24, 2024

Conversation

mrcjkb
Copy link
Contributor

@mrcjkb mrcjkb commented May 23, 2024

Hey 👋

Summary

This PR is part of a push to get neovim plugins on LuaRocks.

See also:

Things done:

  • Add a workflow that publishes tags to luarocks.org when a tag or release is pushed.

Notes:

Important

@Olical
Copy link
Owner

Olical commented May 24, 2024

Hmm, so I'm wary of putting secrets in actions that are run by the public, wouldn't this allow someone to print my API key if they submit a PR that changes the action to print it?

@Olical
Copy link
Owner

Olical commented May 24, 2024

Ah I see, the secret would not be readable in fork PRs, so that should be okay.

@Olical Olical merged commit e97e0db into Olical:master May 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants