Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify Class C transaction #339

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Specify Class C transaction #339

merged 3 commits into from
Feb 20, 2020

Conversation

msgilligan
Copy link
Member

Draft/Work-in-progress

dexX7
dexX7 reviewed Jan 29, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
dexX7
dexX7 reviewed Jan 29, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
dexX7
dexX7 reviewed Jan 29, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
dexX7
dexX7 reviewed Jan 29, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
dexX7
dexX7 reviewed Jan 29, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
marvgmail
marvgmail reviewed Feb 5, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
marvgmail
marvgmail reviewed Feb 5, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
marvgmail
marvgmail reviewed Feb 5, 2020
View reviewed changes
README.adoc Show resolved Hide resolved
marvgmail
marvgmail reviewed Feb 5, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
@msgilligan msgilligan marked this pull request as ready for review February 18, 2020 17:10
@msgilligan msgilligan changed the title WIP Class C transactions Specify Class C transaction Feb 18, 2020
achamely
achamely reviewed Feb 20, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
achamely
achamely reviewed Feb 20, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
achamely
achamely reviewed Feb 20, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
achamely
achamely reviewed Feb 20, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
achamely
achamely reviewed Feb 20, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
achamely
achamely reviewed Feb 20, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
achamely
achamely reviewed Feb 20, 2020
View reviewed changes
README.adoc Outdated Show resolved Hide resolved
achamely
achamely requested changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@achamely achamely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added single line comments in all the relevant places where i see things that need to be addresses. There are more but some of the others are in the original document and not relevant to your changes yet.

@msgilligan msgilligan requested a review from achamely February 20, 2020 20:30
@achamely achamely merged commit f9da8c2 into OmniLayer:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achamely achamely achamely approved these changes

@dexX7 dexX7 Awaiting requested review from dexX7

@CraigSellars CraigSellars Awaiting requested review from CraigSellars

@marvgmail marvgmail Awaiting requested review from marvgmail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msgilligan @marvgmail @dexX7 @achamely