Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Joey Robichaud <[email protected]>
  • Loading branch information
filipw and JoeRobich authored Oct 2, 2020
1 parent a9da2fc commit e79d1e4
Showing 1 changed file with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ protected override object Invoke(MethodInfo targetMethod, object[] args)
.First()
.MakeGenericMethod(extractClassMemberAnalysisResultType).Invoke(null, new object[]
{
// at this point we have IEnumerable<object> and need to cas to IEnumerable<ExtractClassMemberAnalysisResult>
// at this point we have IEnumerable<object> and need to cast to IEnumerable<ExtractClassMemberAnalysisResult>
// which we can then pass to ImmutableArray.CreateRange<ExtractClassMemberAnalysisResult>()
genericCast.Invoke(null, new object[]
{
// this constrcutor corresponds to
// this constructor corresponds to
// http://sourceroslyn.io/#Microsoft.CodeAnalysis.Features/ExtractClass/ExtractClassOptions.cs,ced9042e0a010e24
// public ExtractClassMemberAnalysisResult(ISymbol member,bool makeAbstract)
// if it changes, this implementation must be changed accordingly
Expand All @@ -68,7 +68,7 @@ protected override object Invoke(MethodInfo targetMethod, object[] args)

const string name = "NewBaseType";

// this constrcutor corresponds to
// this constructor corresponds to
// http://sourceroslyn.io/#Microsoft.CodeAnalysis.Features/ExtractClass/ExtractClassOptions.cs,6f65491c71285819,references
// public ExtractClassOptions(string fileName, string typeName, bool sameFile, ImmutableArray<ExtractClassMemberAnalysisResult> memberAnalysisResults)
// if it changes, this implementation must be changed accordingly
Expand Down

0 comments on commit e79d1e4

Please sign in to comment.