Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't deploy .NET Core SDKs #765

Closed
DustinCampbell opened this issue Feb 11, 2017 · 1 comment
Closed

Don't deploy .NET Core SDKs #765

DustinCampbell opened this issue Feb 11, 2017 · 1 comment
Assignees
@DustinCampbell
Labels
fixed

Comments

@DustinCampbell
Copy link
Contributor

Today, we deploy the .NET Core SDKs with OmniSharp to make everything work with MSBuild and .csproj. However, we really shouldn't. Instead, we should set the "MSBuildSDKsPath" environment variable to the SDKs that are deployed with the .NET Core SDK (e.g. the CLI). However, there's a bit of extra work here to discover where the .NET Core SDK is installed and which .NET Core SDK is specified in the user's global.json.
@DustinCampbell
Copy link
Contributor Author

Note that this should shrink the OmniSharp .zips down significantly.

@DustinCampbell DustinCampbell self-assigned this Feb 14, 2017
@DustinCampbell DustinCampbell mentioned this issue May 3, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DustinCampbell DustinCampbell

Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DustinCampbell