Fix 1.26.1 bugs #1016
Merged
Fix 1.26.1 bugs #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage for Linux users Fixes OmniSharp#1011
filipw
approved these changes
Nov 9, 2017
rchande
approved these changes
Nov 9, 2017
|
|
||
| // Simple check to see if this is Windows | ||
| var platformId = (int)Environment.OSVersion.Platform; | ||
| if (platformId <= 3 || platformId == 5) |
There was a problem hiding this comment.
Can you add a comment explaining where this knowledge came from?
There was a problem hiding this comment.
I'll try to remember where it came from. This is derived from scripts/platform.cake
There was a problem hiding this comment.
Oh right. It was this:
| Member | Underlying value |
|---|---|
| Win32S | 0 |
| Win32Windows | 1 |
| Win32NT | 2 |
| WinCE | 3 |
| Unix | 4 |
| Xbox | 5 |
| MacOSX | 6 |
Will add a comment
|
cc @akshita31 and @TheRealPiotrP |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1011
Fixes #1014
This PR addresses a couple of MSBuild discovery issues:
Microsoft.Build.dllis missing. This can happen on Linux layouts of Mono when the user hasn't installed themsbuildpackage yet.