Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't parse ASP.NET websites #1066

Merged
merged 7 commits into from
Jan 11, 2018

Conversation

jmbeach
Copy link
Contributor

@jmbeach jmbeach commented Dec 15, 2017

Fixes issue "The given path's format is not supported" #1036 when you have an ASP.NET website in your solution.

Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change makes sense to me, @DustinCampbell ?

There is a lot of magic around Asp Websites that I don't think we're prepared to support at this time.

@jmbeach
Copy link
Contributor Author

jmbeach commented Dec 19, 2017

Travis ci timed out...

@@ -43,6 +43,11 @@ private ProjectBlock(string projectTypeGuid, string projectName, string relative
Sections = sections;
}

public bool IsAspWebsite()
{
return RelativePath.StartsWith("http://");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it should probably be case insensitive. can this be https:// too?
btw, do you have a sample project like this? I don't think it's possible to create these types of projects in VS for quite a while now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My project was made in Visual Studio 2013 for my work.

Steps to make one:

  • Right click solution item in solution explorer
  • Add
    • New website

The option is still there in Visual Studio 2017 Community Edition. Don't know if it works the same.

@david-driscoll
Copy link
Member

Yay mac builds, going to see if this one passes, if it doesn't I'm sure things change wasn't the culprit and I'll merge anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants