Disable cake diagnostics endpoint for requests that don't specify a file #1107
Conversation
Cake's diagnostics engine calls the generic CodeCheckService, which generates all diagnostics for the solution if called without a specific file path. This results in duplicate errors in C# projects when VS Code requests project level diagnostics. The solution is to only compute diagnostics for specified files. Fixes dotnet/vscode-csharp#1830
|
|
||
| return await TranslateResponse(response, request); | ||
| } | ||
|
|
||
| public virtual Task<TResponse> HandleCore(TRequest request, IRequestHandler<TRequest, TResponse> service) |
There was a problem hiding this comment.
Is it necessary to introduce this? Task<TResponse> Handle(TRequest request) is already virtual.
| @@ -14,5 +15,15 @@ public class CodeCheckHandler : CakeRequestHandler<CodeCheckRequest, QuickFixRes | |||
| : base(workspace) | |||
| { | |||
| } | |||
|
|
|||
| public override Task<QuickFixResponse> HandleCore(CodeCheckRequest request, IRequestHandler<CodeCheckRequest, QuickFixResponse> service) | |||
There was a problem hiding this comment.
Override Task<TResponse> Handle(TRequest request) instead.
| return Task.FromResult(new QuickFixResponse()); | ||
| } | ||
|
|
||
| return service.Handle(request); |
There was a problem hiding this comment.
Override Task Handle(TRequest request) and call base.Handle(request) instead?
|
@mholo65 It seems like Handle() does a bunch of pre- and post-processing on the request and result type that every overrider shouldn't have to be concerned with. I therefore added HandleCore where endpoints only have to be concerned with the actual call to the underlying service. Thoughts? |
|
@rchande that’s a valid point. Instead of adding a new |
|
@mholo65 Good idea, I'll do that. |
| var diagnostics = await FindDiagnostics(input, includeFileName: false); | ||
| Assert.Null(diagnostics); | ||
| } | ||
| private async Task<QuickFixResponse> FindDiagnostics(string contents, bool includeFileName) |
| @@ -54,11 +54,15 @@ protected CakeRequestHandler(OmniSharpWorkspace workspace) | |||
|
|
|||
| request = await TranslateRequestAsync(request); | |||
|
|
|||
| var response = await service.Handle(request); | |||
| var response = IsValid(request) | |||
There was a problem hiding this comment.
Maybe check validity before TranslateRequest?
Cake's diagnostics engine calls the generic CodeCheckService, which generates all diagnostics for the solution if called without a specific file path. This results in duplicate errors in C# projects when VS Code requests project level diagnostics. The solution is to only compute diagnostics for specified files.
Fixes dotnet/vscode-csharp#1830
Diagnostics window in VS Code now looks like:
cc @mholo65