-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable DotNetProjectSystem by default #1194
Disable DotNetProjectSystem by default #1194
Conversation
Note: I submitted this change based on the conversation we had during the last OmniSharp call. If this is not what we want, we can just set |
We also have a first level of configuration via an optional We used to ship it in the past, but then at some point it got lost (I really don't know what happened to it, I think it genuinely got lost) and it's not there anymore (though it was only setting some defaults for dotnet project system AFAIR and the defaults are hardcoded anyway). So technically the same effect could be achieved by re-shipping the
Regardless, I'm voting with my hand and feet to have the dotnet project system disabled by default 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@DustinCampbell looks like one file has conflicts, would you mind resolving? |
This change threads through a new `IProjectSystem.EnabledByDefault` property and sets it to false for the legacy project.json project system.
95bde5d
to
1ed39fc
Compare
that one is a good reason to celebrate 😃 |
This change threads through a new
IProjectSystem.EnabledByDefault
property and sets it to false for the legacy project.json project system.