Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable DotNetProjectSystem by default #1194

Merged

Conversation

DustinCampbell
Copy link
Contributor

This change threads through a new IProjectSystem.EnabledByDefault property and sets it to false for the legacy project.json project system.

@DustinCampbell
Copy link
Contributor Author

Note: I submitted this change based on the conversation we had during the last OmniSharp call. If this is not what we want, we can just set EnabledByDefault to true for the DotNetProjectSystem. Having the mechanism is still nice. 😄

@filipw
Copy link
Member

filipw commented May 18, 2018

We also have a first level of configuration via an optional config.json file loaded here.

We used to ship it in the past, but then at some point it got lost (I really don't know what happened to it, I think it genuinely got lost) and it's not there anymore (though it was only setting some defaults for dotnet project system AFAIR and the defaults are hardcoded anyway).

So technically the same effect could be achieved by re-shipping the config.json at OmniSharp root again, with the following content:

{
  "dotnet": {
     "enabled": false
  }
}

Regardless, I'm voting with my hand and feet to have the dotnet project system disabled by default 😀

Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@filipw
Copy link
Member

filipw commented Jun 5, 2018

@DustinCampbell looks like one file has conflicts, would you mind resolving?

This change threads through a new `IProjectSystem.EnabledByDefault` property
and sets it to false for the legacy project.json project system.
@DustinCampbell DustinCampbell force-pushed the project-systems-enabled-by-default branch from 95bde5d to 1ed39fc Compare June 5, 2018 13:19
@filipw filipw merged commit 5129ba5 into OmniSharp:master Jun 5, 2018
@filipw
Copy link
Member

filipw commented Jun 5, 2018

that one is a good reason to celebrate 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants