GH1214: Add cake handler for /codestructure endpoint. #1217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
reviewed
Jun 7, 2018
| { | ||
| var translatedElement = await childElement.TranslateAsync(workspace, request); | ||
|
|
||
| // This is plain stupid, but someone might put a #load directive inside a method or class |
There was a problem hiding this comment.
is this supported in Cake?
In scripting this would generate CS8098 "Cannot use #load after first token in file"
https://github.com/dotnet/roslyn/blob/ca2f6ad9ab68518344c2d3e25c0731c83d136701/src/Compilers/CSharp/Portable/Errors/ErrorCode.cs#L1329
There was a problem hiding this comment.
Yes it is supported since Cake only includes the content of #load:ed files. It doesn't rely on the Roslyn #load directive currently. I'm about to look into changing that behavior however 😄
DustinCampbell
approved these changes
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Fixes #1214