Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix refusing HTTP connections ( #1274 ) #1361

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

JulioJu
Copy link
Contributor

@JulioJu JulioJu commented Dec 12, 2018

See especially #1274 (comment) and the work with @nickspoons

@nickspoons
Copy link
Member

I can confirm that copying the files listed in DeleteUnnecessaryAssemblies in build.cake from bin/Debug/OmniSharp.Http.Driver/net461/ to artifacts/publish/OmniSharp.Http.Driver/mono results in a useable OmniSharp-roslyn server which responds to HTTP requests and can therefore be used by OmniSharp-vim.

@JulioJu
Copy link
Contributor Author

JulioJu commented Dec 15, 2018

Deletion of this files are added in the commit b1e533c named "Build: Create 'PublishMonoBuilds' target" by @DustinCampbell committed on Aug 3, 2017

The first release with the deletion of this files was 1.23.0 (https://github.com/OmniSharp/omnisharp-roslyn/releases/tag/v1.23.0).

@JulioJu
Copy link
Contributor Author

JulioJu commented Jan 8, 2019

@rchande as you are very active here, I ask you what you think about that :-)

Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change should be pretty minor. Now that we've discussed what is really happening here. Thanks @JulioJu . Sorry for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants