Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for NullableContextOptions in csproj #1404

Merged
merged 5 commits into from
Feb 27, 2019
Merged

Support for NullableContextOptions in csproj #1404

merged 5 commits into from
Feb 27, 2019

Conversation

filipw
Copy link
Member

@filipw filipw commented Feb 20, 2019

Correctly propagate NullableContextOptions from csproj into CSharpCompilationOptions
Fixes #1396

@filipw filipw mentioned this pull request Feb 26, 2019
Closed
@rchande
Copy link

rchande commented Feb 26, 2019

Thanks! LGTM

@filipw filipw merged commit 1ce3392 into OmniSharp:master Feb 27, 2019
@filipw filipw deleted the bugfix/1396 branch February 27, 2019 07:42
@filipw
Copy link
Member Author

filipw commented Feb 27, 2019

thanks - merging

@filipw filipw mentioned this pull request Mar 5, 2019
Closed
@filipw filipw mentioned this pull request Apr 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchande rchande rchande approved these changes

@DustinCampbell DustinCampbell Awaiting requested review from DustinCampbell

@david-driscoll david-driscoll Awaiting requested review from david-driscoll

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipw @rchande