Use mono 6.4.0 #1640
Use mono 6.4.0 #1640
Conversation
| "MonoRuntimeLinux32": "mono.linux-x86-6.4.0.198.zip", | ||
| "MonoRuntimeLinux64": "mono.linux-x86_64-6.4.0.198.zip", | ||
| "MonoMSBuildRuntime": "Microsoft.Build.Runtime.Mono-6.4.0.198.zip", | ||
| "MonoMSBuildLib": "Microsoft.Build.Lib.Mono-6.4.0.198.zip", |
There was a problem hiding this comment.
maybe we can drop this completely. at the moment, the way build script has been changed recently - it doesn't take msbuild from these ZIPs anyway, it copies it from the global Mono on the build agent (since those are configured to use Mono 6.4.0).
There was a problem hiding this comment.
the embedded mono, on the contrary, is still taken from here so that part is still relevant
There was a problem hiding this comment.
Ah, so a minimal install of mono is now built into and installed with omnisharp instead of omnisharp installing these artifacts?
There was a problem hiding this comment.
Nevermind my assumption, apparently github only loaded the first of your comments.
There was a problem hiding this comment.
yeah no problem 😀
it's not immediately obvious as the build script is quite convoluted, but basically "both" (I quote "both" since there is more of them, but there are two variants - mono and msbuild) these ZIPs are downloaded at build time and embedded into the produced packages. however, since recent changes to move to msbuild 16.3, the msbuild binaries are actually copied from build agent's mono so the msbuild zip here is probably redundant (or we go back to the original approach and stop copying it from build agent's mono).
There was a problem hiding this comment.
Any reason to not go "all in" on the build script and let it package mono as well?
There was a problem hiding this comment.
that would make sense to me 👍 especially as it would also make it easier to move to newer versions of mono
in practice it would mean running the mono packaging script instead of this code https://github.com/OmniSharp/omnisharp-roslyn/blob/master/build.cake#L141-L164 at build time
There was a problem hiding this comment.
LGTM! we can do the change discussed here https://github.com/OmniSharp/omnisharp-roslyn/pull/1640/files#r339205666 separately
for now what is important is that the bundled Mono is 6.4.0-based 👏
|
I agree. I'll try to find some time to look into the build changes. |
No description provided.