Fix folder deletion with VSCode #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review @filipw @JoeRobich @david-driscoll |
david-driscoll
approved these changes
Jun 6, 2020
filipw
reviewed
Jun 6, 2020
| @@ -18,6 +20,16 @@ public void Notify(string filePath, FileChangeType changeType = FileChangeType.U | |||
| { | |||
| lock (_gate) | |||
| { | |||
| if(changeType == FileChangeType.DirectoryDelete) | |||
| { | |||
| foreach(var matchingCallback in _callbacksMap.AsEnumerable().Where(x => x.Key.StartsWith(filePath + Path.DirectorySeparatorChar, StringComparison.OrdinalIgnoreCase))) | |||
There was a problem hiding this comment.
isn't this going to end up calling OnDocumentRemoved twice on a file? once from here as a file and then again through the directory?
There was a problem hiding this comment.
True, i will remove that part as it's unnecessary.
Original idea were to hide directory removal specifics from subscribers of file watcher, however since it uses other than full paths (extensions etc) too it were not possible and this was left behind from that version.
Removed at e90ea72
…thub.com/savpek/omnisharp-roslyn into feature/attempt-to-fix-folder-deletion-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCode has issue (however by design at current version) where removed folders doesn't send any notifications of removed files because file watcher has some kind of performance optimizations to ignore them.
However watching folders removal is possible. This PR adds support for omnishar-roslyn side so clients can notify removed directory instead of single files if needed -> which can be impelemented properly with current VSCode file watcher.
This fixes one of most common issue that requires omnisharp restart on any directory rename/move/... operation.
Vscode side implementation: dotnet/vscode-csharp#3829