Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the real MSBuild version during discovery #1876

Merged
merged 3 commits into from
Aug 7, 2020
Merged

Use the real MSBuild version during discovery #1876

merged 3 commits into from
Aug 7, 2020

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented Aug 6, 2020 •
edited
Loading

Read the product version for the MSBuild that is discovered.

Makes #1875 more useful.

filipw
filipw approved these changes Aug 7, 2020
View reviewed changes
Copy link
Member

@filipw filipw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this was long overdue. I may or may not confirm that I hardcoded these values here in the first place 😅

@filipw filipw merged commit 6dc6c96 into OmniSharp:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipw filipw filipw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoeRobich @filipw