Fix MSBuild version mismatch with new SDKs #1883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeRobich
commented
Aug 12, 2020
Comment on lines
+212
to
216
| var msbuildRefLibraries = new [] | ||
| { | ||
| "Microsoft.Build.Tasks.v4.0", | ||
| "Microsoft.Build.Tasks.v12.0", | ||
| "Microsoft.Build.Utilities.v4.0", |
There was a problem hiding this comment.
There are no NuGet packages for these but we can still copy them from the Mono MSBuild folder.
Comment on lines
+60
to
+63
| <PackageReference Update="NuGet.Packaging" Version="$(NuGetPackageVersion)" /> | ||
| <PackageReference Update="NuGet.Packaging.Core" Version="$(NuGetPackageVersion)" /> | ||
| <PackageReference Update="NuGet.ProjectModel" Version="$(NuGetPackageVersion)" /> | ||
| <PackageReference Update="NuGet.Versioning" Version="$(NuGetPackageVersion)" /> |
There was a problem hiding this comment.
This only seemed to be an issue in the Linux build surprisingly
Comment on lines
-152
to
-158
| SendMessage(MessageType.GetTestRunnerProcessStartInfoForRunSelected, | ||
| new | ||
| { | ||
| TestCases = testCases, | ||
| DebuggingEnabled = true, | ||
| RunSettings = LoadRunSettingsOrDefault(runSettings, targetFrameworkVersion) | ||
| }); |
There was a problem hiding this comment.
This should have been removed when I extracted out the GetTestRunningProcessStartInfo method
Comment on lines
+11
to
+24
| private const string DotNetVersion = "3.1.401"; | ||
| private int Major { get; } | ||
| private int Minor { get; } | ||
| private int Patch { get; } | ||
| private string Release { get; } | ||
|
|
||
| public DotNetCliServiceFacts(ITestOutputHelper output) | ||
| : base(output) | ||
| { | ||
| var version = SemanticVersion.Parse(DotNetVersion); | ||
| Major = version.Major; | ||
| Minor = version.Minor; | ||
| Patch = version.Patch; | ||
| Release = version.Release; |
There was a problem hiding this comment.
This should make future SDK updates easier since the version string can be updated with a replace all.
JoeRobich
changed the title
filipw
approved these changes
Aug 12, 2020
This was referenced Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 3.1.401 SDK's minimumMSBuildVersion is 16.7.0. The latest stable and preview versions of Mono ship with 16.6.0. This causes the DotNet.MSBuildSDKResolver to no longer find the sdks needed to load projects.
Possibilities for working around this:
Since we already ship the MSBuild from tools/packages on the Windows platform, this may be the easiest path to take.
Fixes dotnet/vscode-csharp#3951