Updated lsp library to fix issue with signature help, etc #1890
Conversation
|
Tested locally and signature help is working as expected (and returning null when it should be!) |
|
looks like I might have some failing tests, let's see what I broke... :) |
|
kid hollering from the back seat... "Are we there, yet?" 😄 (same kid doesn't even know if this build fixes his problem...) |
|
okay I'm stumped at the moment. Using our embedded mono the tests stall (for what reason I can't really tell, it just gets "stuck"). With full mono it runs and passes no issues. There have been some internal changes internal to the library however it gets more confusing because it works with netcoreapp2.1, netcoreapp3.1, net472 (windows), net472(full mono). Anyone have any ideas what I might need to add to the embedded mono for things to work? or magic commands I can run to help trace the issue? I've got everything setup in wsl2 and can replicate the issue that is in CI. |
|
maybe you now have new types that are missing? https://github.com/OmniSharp/omnisharp-roslyn/blob/master/mono-packaging/copy-mono.sh#L91 |
Fixes: #1887