Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handle completion when the display text is not in the final result #1908

Merged
merged 3 commits into from
Aug 22, 2020
Merged

Better handle completion when the display text is not in the final result #1908

merged 3 commits into from
Aug 22, 2020

Commits on Aug 21, 2020

  1. Better handle completion when the display text is not in the final re… 

    …sult

Override and partial method completion can have scenarios where the DisplayText of the completion item does not appear in the final text, such as when types need to be imported or when nullability differs between original declaration and generation declaration sites. We now handle these by parsing the change if we fail to find the insertion text, and using the last method in the change to find the correct location in the new text. Fixes OmniSharp#1907.
    @333fred
    333fred committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    220cb4c View commit details
    Browse the repository at this point in the history

  2. Fix baselines.

    @333fred
    333fred committed Aug 21, 2020
    Configuration menu
    Copy the full SHA
    125cd74 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2020

  1. Merge branch 'master' into master

    @filipw
    filipw authored Aug 22, 2020
    Configuration menu
    Copy the full SHA
    1f64a7b View commit details
    Browse the repository at this point in the history