Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly mark hover markup content as markdown #1909

Merged
merged 3 commits into from
Aug 23, 2020

Conversation

333fred
Copy link
Contributor

@333fred 333fred commented Aug 21, 2020

We were missing a flag. Fixes #1906.

@333fred
Copy link
Contributor Author

333fred commented Aug 22, 2020

I'm reasonably certain this PR is not causing those test failures.

@filipw
Copy link
Member

filipw commented Aug 23, 2020

yep these extern tests are known to fail...

@filipw filipw merged commit 8f1b99b into OmniSharp:master Aug 23, 2020
@333fred 333fred deleted the hover-markdown branch August 23, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

textDocument/hover response is plaintext but should be markdown?
2 participants