Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added binding redirects for Microsoft.CodeAnalysis.Features and Microsoft.CodeAnalysis.CSharp.Features #1964

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

filipw
Copy link
Member

@filipw filipw commented Sep 28, 2020

This is a best guess attempt to improve the behavior mentioned in dotnet/vscode-csharp#4090

The error is vague but looks like somehow there are different versions of CompletionList loaded simultaneously.
At the moment there are no binding redirects for its parent assembly Microsoft.CodeAnalysis.Features so it wouldn't hurt to add that.

cc @333fred

Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants