Add support for textDocument/implementation in LSP mode #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
filipw
reviewed
Oct 5, 2020
| @@ -39,6 +39,11 @@ public async Task<QuickFixResponse> Handle(FindImplementationsRequest request) | |||
| var quickFixes = new List<QuickFix>(); | |||
| var symbol = await SymbolFinder.FindSymbolAtPositionAsync(semanticModel, position, _workspace); | |||
|
|
|||
| if (symbol == null) | |||
There was a problem hiding this comment.
ugh I can't believe it wasn't there already
|
@arjenwitteveen thank you so much! You probably did the exact same thing I would have done (use references as the base!). 🎈 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds the LSP handler for the
textDocument/implementationfeature (resolves #1853) and tests to go along with it. I tried the feature in Emacs using thelsp-modepackage with success.Writing the handler seemed straightforward. I based the new test class on ReferenceHandlerFacts.cs (I wasn't sure which naming convention to follow, i.e., using the
OmniSharpprefix or not; based on the existing test files I chose to include the prefix).The null check with early return in FindImplementationsService.cs was needed since a NullReferenceException would occur when checking
!symbol.IsAbstractwhen a request was done without pointing at a symbol (the testCannotFindImplementationsWithoutSymbolchecks this case).