-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editorconfig improvements - do not lose state, trigger re-analysis on change #2028
Conversation
5f2f7eb
to
5fe1264
Compare
Wow, this is great! Can't wait until this is released. Nicely done! |
this PR requires this change to ship with the C# Extension dotnet/vscode-csharp#4230 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CompilationOptions
based on the csproj file when a project update is triggered (e.g. rebuild, change in csproj). This causes us to lose the editorconfig state because it is kept inSyntaxTreeOptionsProvider
which gets reset then. The PR ensures the new compilation options are created only when necessary, and also derived from the previous ones.AnalyzerConfigDocumentChanged
) which is now newly handled to trigger re-analysis.