Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use an OmniSharp specific message for MSB3644 #2069

Merged
merged 4 commits into from
Jan 24, 2021

Conversation

filipw
Copy link
Member

@filipw filipw commented Jan 22, 2021

fixes #2029

Instead of printing the default MSBuild message for MSB3644 which is Windows specific and has been very confusing to the users:

The reference assemblies for {0} were not found. To resolve this, install the Developer Pack (SDK/Targeting Pack) for this framework version or retarget your application. You can download .NET Framework Developer Packs at https://aka.ms/msbuild/developerpacks

we now change it into a more relevant OmniSharp message on Unix:

This project targets .NET version that requires reference assemblies that do not ship with OmniSharp out of the box (e.g. .NET Framework). The most common solution is to make sure Mono is installed on your machine (https://mono-project.com/download/) and that OmniSharp is started with that Mono installation (e.g. 'omnisharp.useGlobalMono':'always' in C# Extension for VS Code).

Copy link
Member

@JoeRobich JoeRobich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change

@filipw filipw merged commit aaf1fef into master Jan 24, 2021
@filipw filipw deleted the feature/better-mono-error-messages branch January 24, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Catch "The reference assemblies (...) were not found." project loader exception and provide better information
2 participants