Reuse Roslyn's analyzer assembly loader #2236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
reviewed
Sep 25, 2021
jasonmalinowski
force-pushed
the
reuse-roslyns-analyzer-loader
branch
from
6b9254f
to
07c16e2
Compare
jasonmalinowski
commented
Dec 2, 2021
src/OmniSharp.Roslyn.CSharp/Services/Completion/CompletionOptionsProvider.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
commented
Dec 2, 2021
src/OmniSharp.Roslyn.CSharp/Services/Completion/CompletionService.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
force-pushed
the
reuse-roslyns-analyzer-loader
branch
from
07c16e2
to
349f08c
Compare
Roslyn has made some improvements to better handle the case where analyzers or generators have a mix of assembly versions, such as in microsoft/CsWin32#218. The Roslyn changes were made in dotnet/roslyn#56432, and this consumes it.
jasonmalinowski
force-pushed
the
reuse-roslyns-analyzer-loader
branch
from
349f08c
to
85f35cf
Compare
jasonmalinowski
commented
Jan 26, 2022
| { | ||
| public static class ShadowCopyAnalyzerAssemblyLoader | ||
| { | ||
| public static readonly IAnalyzerAssemblyLoader Instance = OmnisharpAnalyzerAssemblyLoaderFactory.CreateShadowCopyAnalyzerAssemblyLoader(); |
There was a problem hiding this comment.
This is here because the Omnisharp.Host project doesn't have internals access to Microsoft.CodeAnalysis.ExternalAccess.Omnisharp; I don't know if that was an accidental oversight or intentional layering, but following it for now.
There was a problem hiding this comment.
I'm sure it just wasn't necessary for the initial round of reflection removal. This seems fine for now.
|
This is now ready for review now that we sorted everything else out. |
JoeRobich
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roslyn has made some improvements to better handle the case where analyzers or generators have a mix of assembly versions, such as in microsoft/CsWin32#218. The Roslyn changes were made in dotnet/roslyn#56432, and this consumes it.