Update versions from 6.0.1xx #2239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipw
reviewed
Oct 1, 2021
| --> | ||
|
|
||
| <!-- These packages should match the "MicrosoftNETSdkPackageVersion" property--> | ||
| <package id="Microsoft.NET.Sdk" version="6.0.100-rc.1.21427.66" /> | ||
| <package id="Microsoft.DotNet.MSBuildSdkResolver" version="6.0.100-rc.1.21427.66" /> | ||
| <package id="Microsoft.NET.Sdk" version="6.0.100-rtm.21480.28" /> |
There was a problem hiding this comment.
are these the ones envisioned for RTM already?!
There was a problem hiding this comment.
@filipw Sorry, I don't know how to answer that. I only copied the versions from the release/6.0.1xx branch.
There was a problem hiding this comment.
I think ideally we would have used the packages from https://github.com/dotnet/sdk/tree/release/6.0.1xx-rc2 since RC2 is about to release. Once we have a new build we can validate against RC2 and see if this is going to be a problem or not.
There was a problem hiding this comment.
right - that was exactly my question here too - I thought that perhaps RC2 was not happening anymore if the RTM versions are there now? I am not privvy to all these plans 😀
filipw
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.