Remove all completion commit characters in suggestion mode. #2253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
reviewed
Oct 19, 2021
src/OmniSharp.Roslyn.CSharp/Services/Completion/CompletionListBuilder.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When suggestion mode completion items were returned, we were removing the space character from the item's commit characters. This still left other punctuation as potential commit characters for the items. To truly simulate a suggestion mode, we should force the editor to fallback to <tab> or <enter> for committing the suggestions.
This should resolve several issues.
dotnet/vscode-csharp#1974
dotnet/vscode-csharp#3219
dotnet/vscode-csharp#3647
dotnet/vscode-csharp#4833