-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analyze open documents only #2346
Add analyze open documents only #2346
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! - any thoughts @333fred @JoeRobich ?
tests/OmniSharp.Roslyn.CSharp.Tests/CustomRoslynAnalyzerFacts.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Joey Robichaud <[email protected]>
Wooo! Thanks so much for this folks, this is my first real contribution to a public repo, feels good to help out ❤️ |
@neoGeneva, would you want to submit a PR to the vscode to add the option? You'll need to:
My suggestion would be off (false) by default for this setting. |
Sweet, thanks @333fred, I've got most of it ready to go, but it got mixed up with some other stuff I was looking at, just splitting it out into its own branch so I can do a pull request a little later. |
Hey, this is a pull requestion to add an
AnalyzeOpenDocumentsOnly
option toRoslynExtensionsOptions
, whichCSharpDiagnosticWorkerWithAnalyzer
uses to decided if it runs full roslyn anaylizers or just the base diagnostics provided bysyntaxTree.GetDiagnostics()
.The main benefit is the speed of the initial analysis of all files in the solution. For large solutions this is pretty handy, for example the roslyn solution takes 18 minutes for that first pass, vs. 1 minute with
AnalyzeOpenDocumentsOnly
set to true.