Return meaningful error when pinned SDK version is not found. #2403
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in dotnet/vscode-csharp#5128
As part of creating the TestManager OmniSharp attempts to parse the .NET CLI version. When a global.json is being used by a project and the SDK version pinned in the SDK is not installed a detailed error message is output to a combination of stderr and stdout. OmniSharp would then fail to parse a valid SemanticVersion from this output and the user would be given a generic FormatException. This change adds additional parsing of the output when it is not a valid SemanticVersion to provide the user with a more meaningful error.
Prior to this change users would see the following error in their OmniSharp log:
With this change they will see a more actionable message.
Example from VS Code: